Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable auto-merge on minor updates. #1783

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Enable auto-merge on minor updates. #1783

wants to merge 2 commits into from

Conversation

Jaehwa-Noh
Copy link
Contributor

@Jaehwa-Noh Jaehwa-Noh commented Dec 25, 2024 •
edited
Loading

What I have done and why

Reference by automerge documentation.
https://docs.renovatebot.com/configuration-options/#automerge

  "packageRules": [
    {
      "matchUpdateTypes": ["minor", "patch", "pin", "digest"],
      "automerge": true
    }
  ]
}

Fix #1782

Try to grouping only minor and patch bump up to use an automerge.
https://docs.renovatebot.com/presets-group/#groupallnonmajor

@Jaehwa-Noh Jaehwa-Noh mentioned this pull request Dec 25, 2024
Merged
@SimonMarquis
Copy link
Contributor

SimonMarquis commented Dec 25, 2024 •
edited
Loading

We are already inheriting this configuration that should be equivalent

https://github.com/android/.github/blob/c9c3767d8e4fee5cf3b968c5d4e970ee33973824/renovate-config.json#L8

The main issue is, I think, that we currently only have a global group applied "group:all", which prevents individual PRs to be created and merged separately.

@Jaehwa-Noh
Copy link
Contributor Author

@SimonMarquis I've checked it, and getting you're right.
This project using automerge preset.
I think may we grouping only minor update be use.

I'll edit this PR to do that.

@Jaehwa-Noh Jaehwa-Noh marked this pull request as draft December 25, 2024 06:09
@Jaehwa-Noh Jaehwa-Noh marked this pull request as ready for review December 25, 2024 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Renovate doesn't do an auto-merge.
2 participants
@Jaehwa-Noh @SimonMarquis